This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover devices may or may not support setting their position (ie, an arbitrary
value between 0 and 100) instead of just opening or closing.
Before this change, it was assumed that rollershutters could have their
set, but garage doors could not. This is not correct.
This refactors the cover accessory to make this separation more clear. Instead
of if statements scattered through the code, we build a class hierarchy to
clearly separate garage doors and rollershutters - of the "binary" type, and
the type we previously assumed all were.
It also moves towards a more consistent way of handling the door states, using the HAP constants.
At the same time, I moved all of the logic for choosing the cover type into
the cover factory, instead of doing it all in index.js
It also fixes some bugs - onEvent handling works for rollershutters now.