Add proxy for network and resolution endpoints #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forward the requests to the network and resolution endpoints to the Supervisor. This will allow the landing page to get insights when the Supervisor detects issues on first startup (e.g. problematic DNS servers). The network endpoint will allow to resolve these issues. Note: This makes the two mentioned endpoints available unauthenticated. However, the landing page will be replaced with Core as soon as it has been downloaded, so this unauthenticated forwarding will only be during a brief phase on initial setup. A bad actor could also just setup a new user from the onboarding page at this point in time. So this effectly does not change the security posture.
sairon
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward the requests to the network and resolution endpoints to the Supervisor. This will allow the landing page to get insights when the Supervisor detects issues on first startup (e.g. problematic DNS servers). The network endpoint will allow to resolve these issues.
Note: This makes the two mentioned endpoints available unauthenticated. However, the landing page will be replaced with Core as soon as it has been downloaded, so this unauthenticated forwarding will only be during a brief phase on initial setup. A bad actor could also just setup a new user from the onboarding page at this point in time. So this effectly does not change the security posture.