-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spruce up ui, minor formatting #86
Conversation
Thanks for cleaning up this page! By removing the app and play store badges it also removes attention to the most prominent action (I think) we want to show. It would be better to upgrade them with the newer ones. Can we check if a user is viewing this page via our app? In that case we can drop these badges. You have to click the icon button to open the link? Some of the icons need a label for users to understand what it mean, for example discord. Maybe is a |
by list, do you mean i should make it so each link is on its own row? |
Yes
Good question. I thought so, the authentication page is shown because the authentication page is not ready yet. |
did you mean to say "the onboarding page is shown"? |
Whoops, yes. Had a chat and looks like it's difficult to know if a user is viewing this page via our app. So skip this for now. |
@matthiasdebaat i went ahead and updated it to use the list style. i also changed the style a bit and removed some unused css while i was at it. it looks like this now: |
Nice! In English the title fits perfectly, what does it look like for other languages with more characters? Can you add chevrons to the list items? |
This page is not translated (yet?) so other languages are not a concern here. |
How would chevrons fit in here? I can't think of anything to close or open. |
On the right of every list item. Chevron gives users a better understanding that they can be clicked to go to this page. Alternative we can use |
see latest comments for what this looks like.