Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spruce up ui, minor formatting #86

Merged
merged 6 commits into from
Jun 28, 2023
Merged

spruce up ui, minor formatting #86

merged 6 commits into from
Jun 28, 2023

Conversation

KTibow
Copy link
Contributor

@KTibow KTibow commented May 6, 2023

see latest comments for what this looks like.

@matthiasdebaat
Copy link

Thanks for cleaning up this page!

By removing the app and play store badges it also removes attention to the most prominent action (I think) we want to show. It would be better to upgrade them with the newer ones. Can we check if a user is viewing this page via our app? In that case we can drop these badges.

You have to click the icon button to open the link? Some of the icons need a label for users to understand what it mean, for example discord. Maybe is a list a better option. In the current design and on our settings tip we also call it chat, instead of Discord.
CleanShot 2023-05-15 at 11 07 36@2x

@KTibow
Copy link
Contributor Author

KTibow commented May 15, 2023

by list, do you mean i should make it so each link is on its own row?
also is it even possible to view the onboarding page via the app? doesn't the app go to the authentication page or something?

@matthiasdebaat
Copy link

by list, do you mean i should make it so each link is on its own row?

Yes

also is it even possible to view the onboarding page via the app? doesn't the app go to the authentication page or something?

Good question. I thought so, the authentication page is shown because the authentication page is not ready yet.

@KTibow
Copy link
Contributor Author

KTibow commented May 17, 2023

the authentication page is shown because the authentication page is not ready yet.

did you mean to say "the onboarding page is shown"?

@matthiasdebaat
Copy link

matthiasdebaat commented May 22, 2023

the authentication page is shown because the authentication page is not ready yet.

did you mean to say "the onboarding page is shown"?

Whoops, yes. Had a chat and looks like it's difficult to know if a user is viewing this page via our app. So skip this for now.

@KTibow
Copy link
Contributor Author

KTibow commented Jun 1, 2023

@matthiasdebaat i went ahead and updated it to use the list style. i also changed the style a bit and removed some unused css while i was at it. it looks like this now:
image

@matthiasdebaat
Copy link

Nice!

In English the title fits perfectly, what does it look like for other languages with more characters? Can you add chevrons to the list items?

@ludeeus
Copy link
Member

ludeeus commented Jun 5, 2023

This page is not translated (yet?) so other languages are not a concern here.

@KTibow
Copy link
Contributor Author

KTibow commented Jun 5, 2023

How would chevrons fit in here? I can't think of anything to close or open.
Do you mean the ability to collapse all of the suggestions?

@matthiasdebaat
Copy link

matthiasdebaat commented Jun 6, 2023

How would chevrons fit in here? I can't think of anything to close or open.
Do you mean the ability to collapse all of the suggestions?

On the right of every list item. Chevron gives users a better understanding that they can be clicked to go to this page. Alternative we can use mdi:open-in-new.

@KTibow
Copy link
Contributor Author

KTibow commented Jun 10, 2023

chevrons added 👍
image

@pvizeli pvizeli merged commit 6bfb060 into home-assistant:main Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants