Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Khadas VIM3 support #84

Merged
merged 3 commits into from
Apr 28, 2022
Merged

Add Khadas VIM3 support #84

merged 3 commits into from
Apr 28, 2022

Conversation

agners
Copy link
Member

@agners agners commented Aug 6, 2021

Add sound configuration for Khadas VIM3. Currently only HDMI supported.
This requires access to device tree in sysfs.

@pvizeli
Copy link
Member

pvizeli commented Aug 6, 2021

That will not work because it's mask by docker. We Can pass the machine type over env

@agners
Copy link
Member Author

agners commented Aug 6, 2021

Yes I realized, that is why I set it to draft 😅

We could also enable device tree access for Audio with a Supervisor upgrade I guess? Add-ons have that as an option. Not sure what is better/easier.

@agners
Copy link
Member Author

agners commented Aug 10, 2021

Hm, I see there is currently not a easy way to access the firmware directory in its default location. /proc/device-tree symlinks to /sys/firmware/devicetree/base and /sys/firmware/` directory is in a hard-coded mask list since years: moby/moby@8b1772c

We support non-native location with this pull request: home-assistant/supervisor#519

It seems that a bind mount to a different location works, but the symlink /proc/device-tree can't be changed, so whereever we bind mount it would be non-standard :(

agners added 3 commits April 28, 2022 15:55
Add sound configuration for Khadas VIM3. Currently only HDMI supported.
This requires access to device tree in sysfs.
@agners agners force-pushed the add-khadas-vim3-support branch from 3e5c581 to 2a78776 Compare April 28, 2022 14:09
@agners agners marked this pull request as ready for review April 28, 2022 14:09
@agners
Copy link
Member Author

agners commented Apr 28, 2022

New version using sound device id from sysfs.

@pvizeli pvizeli merged commit 06fb96a into master Apr 28, 2022
@delete-merged-branch delete-merged-branch bot deleted the add-khadas-vim3-support branch April 28, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants