Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fallback to non-SSL whoami call #4751

Merged
merged 5 commits into from
Dec 12, 2023
Merged

Fix fallback to non-SSL whoami call #4751

merged 5 commits into from
Dec 12, 2023

Conversation

agners
Copy link
Member

@agners agners commented Dec 8, 2023

Proposed change

In case of an exception "data" is not set leading to an error: cannot access local variable 'data' where it is not associated with a value

Make sure to fallback to the non-SSL whoami call properly.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

In case of an exception "data" is not set leading to an error:
cannot access local variable 'data' where it is not associated with a value

Make sure to fallback to the non-SSL whoami call properly.
@mdegat01 mdegat01 merged commit 7fef92c into main Dec 12, 2023
22 checks passed
@mdegat01 mdegat01 deleted the fix-whoami-without-ssl branch December 12, 2023 20:24
@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raspberry Pi 3 Fresh installation - no supervisor internet connection
2 participants