Disable uv cache when creating container image #5646
Conversation
We don't intent to run uv again, so the cache is not really useful. The cache directory size is around 80MB, however, the files are mostly hardlinks to the original files in `/usr/local/lib/python3.13/site-packages` so the actual saving is much smaller.
📝 WalkthroughWalkthroughThe Dockerfile has been updated to adjust the installation process for Python packages. The changes replace direct calls to Changes
Sequence Diagram(s)Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Dockerfile (1)
36-41: Conditional Command Prefix & Disabled Caching for Requirements Installation.The conditional block sets the
setarchvariable based on the build architecture (using"linux32"fori386and an empty string otherwise) and then prefixes theuv pip installcommand with that variable. The updated installation command also correctly includes the--no-cacheflag (as well as other options), which aligns with the objective of disabling the uv cache during the container image build.One minor suggestion is to quote the variable substitution (i.e., use
"$setarch"instead of${setarch}) to ensure clarity and to follow best practices in shell scripting, although the current implementation should work as intended.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Dockerfile(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: Build armv7 supervisor
- GitHub Check: Run tests Python 3.13.2
- GitHub Check: Build armhf supervisor
- GitHub Check: Build aarch64 supervisor
🔇 Additional comments (1)
Dockerfile (1)
47-48: Disabled Cache for Home Assistant Supervisor Installation.The updated
uv pip installcommand for the Home Assistant Supervisor now includes the--no-cacheoption. This change is consistent with the PR objective to disable uv caching during image creation and helps reduce the unnecessary disk usage. The subsequent compilation command is also appropriately placed in the same RUN block.
Proposed change
We don't intent to run uv again, so the cache is not really useful. The cache directory size is around 80MB, however, the files are mostly hardlinks to the original files in
/usr/local/lib/python3.13/site-packagesso the actual saving is much smaller.Type of change
Additional information
Checklist
ruff format supervisor tests)If API endpoints or add-on configuration are added/changed:
Summary by CodeRabbit