Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe Robot inserting hardcoded url in URLDownloader for SparkleUpdateInfoProvider download recipe #206

Open
PeetMcK opened this issue Jan 2, 2025 · 1 comment
Assignees
Labels

Comments

@PeetMcK
Copy link

PeetMcK commented Jan 2, 2025

Describe the bug
When creating a recipe for Caffeine.app with the Sparkle appcast url https://dr-caffeine-mac.s3.amazonaws.com/appcast.xml, the resulting recipe hardcodes the url: https://dr-caffeine-mac.s3.amazonaws.com/Caffeine_1.4.3.zip into URLDownloader.

Sorry I can't find other appcast.xml's that cause the same behavior.

To Reproduce
Steps to reproduce the behavior:
/Applications/Recipe\ Robot.app/Contents/Resources/scripts/recipe-robot /Applications/Caffeine.app --ignore-existing --verbose

Caffeine.download.recipe contains:

<dict>
	<key>Arguments</key>
	<dict>
		<key>filename</key>
		<string>%NAME%.zip</string>
		<key>url</key>
		<string>https://dr-caffeine-mac.s3.amazonaws.com/Caffeine_1.4.3.zip</string>
	</dict>
	<key>Processor</key>
	<string>URLDownloader</string>
</dict>

Expected behavior
Caffeine.download.recipe should conatin:

<dict>
	<key>Arguments</key>
	<dict>
		<key>filename</key>
		<string>%NAME%.zip</string>
	</dict>
	<key>Processor</key>
	<string>URLDownloader</string>
</dict>

Screenshots
n/a

Desktop (please complete the following information):

  • macOS: 15.2
  • Recipe Robot Version: 2.3.1
  • autopkg version: 2.7.3
  • /usr/local/autopkg/python --version: Python 3.10.4

Additional context
autopkg/peetinc-recipes#16

@homebysix
Copy link
Owner

@PeetMcK I just pushed some changes to the dev branch that should fix this. I'm going to test thoroughly, but perhaps you could give it a try too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants