Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mac info message on boot normal #216

Merged
merged 2 commits into from
Nov 16, 2016
Merged

Conversation

AlexValois
Copy link
Contributor

When several devices are used and several are waiting their configuration, it is useful to check the mac address in Homie-ota server. Thanks to this change, the mac appear in inventory of the device in homie-ota server.

@marvinroger
Copy link
Member

The DeviceId::get() is not actually the mac address, but something made up of the ESP8266 and flash chip IDs. So $mac is probably bad named.

@AlexValois
Copy link
Contributor Author

Indeed, this is only the last half of the mac to which 0e is added. I will rename it.

thanks

@marvinroger
Copy link
Member

I'll merge this, but thinking about it deviceId is kind of confusing, mac is probably better, even though it's not actually a MAC address.

@marvinroger marvinroger merged commit 0c0a9d4 into homieiot:develop Nov 16, 2016
@jpmens
Copy link

jpmens commented Nov 16, 2016

hwaddr (Hardware address) ?

@jamesmyatt
Copy link
Contributor

jamesmyatt commented Nov 16, 2016

There should be a real (station) MAC address available somewhere. In
Nodemcu, it's wifi.sta.getmac(): https://nodemcu.readthedocs.io/en/master/en/modules/wifi/#wifistagetmac.

@marvinroger
Copy link
Member

I am considering replacing the hardware device ID (which is, as said above, something made up of the ESP8266 and flash chip IDs) by the complete 12 characters MAC address. Read esp8266/Arduino#2309 for the reason why, but TL; DR:

@igrr: There are now more OTP bytes used to set MAC address because we have run out of space with three bytes. getChipID doesn't take these new bytes into account, it has to be updated.
Edit: using MAC address as unique ID a good approach for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants