Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin): fail to initialize GlSyncPoint #515

Merged
merged 2 commits into from
Apr 6, 2022
Merged

fix(plugin): fail to initialize GlSyncPoint #515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90f207c
fix: failed to initialize GlSyncPoint
homuler Apr 6, 2022
74954ee
call a base constructor explicitly
homuler Apr 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Packages/com.github.homuler.mediapipe/Runtime/Scripts/Framework/Formats/ImageFrame.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public ImageFrame(ImageFormat.Format format, int width, int height, uint alignme
this.ptr = ptr;
}

public ImageFrame(ImageFormat.Format format, int width, int height, int widthStep, NativeArray<byte> pixelData)
public ImageFrame(ImageFormat.Format format, int width, int height, int widthStep, NativeArray<byte> pixelData) : base()
{
unsafe
{
Expand Down
2 changes: 1 addition & 1 deletion Packages/com.github.homuler.mediapipe/Runtime/Scripts/Framework/Packet/GpuBufferPacket.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public GpuBufferPacket(GpuBuffer gpuBuffer) : base()
this.ptr = ptr;
}

public GpuBufferPacket(GpuBuffer gpuBuffer, Timestamp timestamp)
public GpuBufferPacket(GpuBuffer gpuBuffer, Timestamp timestamp) : base()
{
UnsafeNativeMethods.mp__MakeGpuBufferPacket_At__Rgb_Rts(gpuBuffer.mpPtr, timestamp.mpPtr, out var ptr).Assert();
GC.KeepAlive(timestamp);
Expand Down
1 change: 0 additions & 1 deletion Packages/com.github.homuler.mediapipe/Runtime/Scripts/Gpu/GlCalculatorHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
// https://opensource.org/licenses/MIT.

using System;
using System.Runtime.InteropServices;

namespace Mediapipe
{
Expand Down
2 changes: 1 addition & 1 deletion Packages/com.github.homuler.mediapipe/Runtime/Scripts/Gpu/GlSyncPoint.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public class GlSyncPoint : MpResourceHandle
{
private SharedPtrHandle _sharedPtrHandle;

public GlSyncPoint(IntPtr ptr) : base(ptr)
public GlSyncPoint(IntPtr ptr) : base()
{
_sharedPtrHandle = new SharedPtr(ptr);
this.ptr = _sharedPtrHandle.Get();
Expand Down
2 changes: 1 addition & 1 deletion Packages/com.github.homuler.mediapipe/Runtime/Scripts/Gpu/GlTextureBuffer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public GlTextureBuffer(IntPtr ptr, bool isOwner = true) : base(isOwner)
/// Make sure that this function doesn't throw exceptions and won't be GCed.
/// </param>
public GlTextureBuffer(uint target, uint name, int width, int height,
GpuBufferFormat format, DeletionCallback callback, GlContext glContext)
GpuBufferFormat format, DeletionCallback callback, GlContext glContext) : base()
{
var sharedContextPtr = glContext == null ? IntPtr.Zero : glContext.sharedPtr;
UnsafeNativeMethods.mp_SharedGlTextureBuffer__ui_ui_i_i_ui_PF_PSgc(
Expand Down