Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace webpack with esbuild #5488

Merged
merged 13 commits into from
Feb 15, 2024
Prev Previous commit
Next Next commit
Fix some lint issues
  • Loading branch information
larsjohnsen committed Jan 8, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 7d0f55512a96f35435375ae67a039a6951b27764
5 changes: 1 addition & 4 deletions lib/css/modules/_commentPreview.scss
Original file line number Diff line number Diff line change
@@ -62,10 +62,7 @@ body.RESScrollLock {
#BigEditor {
position: fixed;
z-index: $zindex-big-editor;
top: 0;
left: 0;
right: 0;
bottom: 0;
inset: 0 0 0 0;
background-color: rgba(0, 0, 0, .75);

> div {
5 changes: 1 addition & 4 deletions lib/css/modules/_dashboard.scss
Original file line number Diff line number Diff line change
@@ -88,10 +88,7 @@

.RESDashboardComponentScrim {
position: absolute;
top: 0;
bottom: 0;
left: 0;
right: 0;
inset: 0 0 0 0;
z-index: 5;
display: none;
}
2 changes: 1 addition & 1 deletion lib/css/modules/_filteReddit.scss
Original file line number Diff line number Diff line change
@@ -10,7 +10,7 @@ body.hideOver18 {
~ * { display: none !important; }
}

html:not(.res-filters-disabled):not(.res-display-match-reason) {
html:not(.res-filters-disabled, .res-display-match-reason) {
.res-thing-filter-hide {
&:not(.res-thing-partial),
&.res-thing-partial.res-thing-hide-children,
3 changes: 1 addition & 2 deletions lib/css/modules/_hover.scss
Original file line number Diff line number Diff line change
@@ -120,8 +120,7 @@

.toggleButton {
margin-left: auto;
justify-content: center;
align-content: center;
place-content: center center;
height: 19px;
}

2 changes: 1 addition & 1 deletion lib/css/modules/_nightMode.scss
Original file line number Diff line number Diff line change
@@ -1239,7 +1239,7 @@ $title-link-visited-color: hsl(0, 0%, 65%);
background-color: rgb(40, 40, 40);
}

.optionContainer:not(.table):not(.specialOptionType) .optionSetting,
.optionContainer:not(.table, .specialOptionType) .optionSetting,
#SearchRES-results-container li,
#RESConfigPanelModulesList > ul,
#RESConfigPanelModulesList li h3,
2 changes: 1 addition & 1 deletion lib/css/modules/_noParticipation.scss
Original file line number Diff line number Diff line change
@@ -20,7 +20,7 @@
cursor: help;
}

&:not(:hover):not(:active) &-contents {
&:not(:hover, :active) &-contents {
display: none;
}
}
5 changes: 1 addition & 4 deletions lib/css/modules/_quickMessage.scss
Original file line number Diff line number Diff line change
@@ -3,10 +3,7 @@
#quickMessage {
display: none;
position: fixed;
top: 0;
bottom: 0;
left: 0;
right: 0;
inset: 0 0 0 0;
background-color: rgba(0, 0, 0, .75);
z-index: $zindex-quick-message-dialog - 1;
}
5 changes: 1 addition & 4 deletions lib/css/modules/_searchHelper.scss
Original file line number Diff line number Diff line change
@@ -38,10 +38,7 @@

> a {
position: absolute;
top: 0;
left: 0;
right: 0;
bottom: 0;
inset: 0 0 0 0;
}
}

8 changes: 2 additions & 6 deletions lib/css/modules/_subredditManager.scss
Original file line number Diff line number Diff line change
@@ -191,8 +191,7 @@

ul {
padding: 15px 0;
overflow-x: hidden;
overflow-y: auto;
overflow: hidden auto;
max-width: 300px;
max-height: 500px;
border-bottom: 1px rgba(0, 0, 0, .5) solid;
@@ -273,10 +272,7 @@
#res-trash-overlay {
transition: opacity .2s;
position: fixed;
top: 20px;
right: 0;
bottom: 0;
left: 0;
inset: 20px 0 0 0;
background-color: rgba(255, 255, 255, .7);
z-index: 999;
}
25 changes: 6 additions & 19 deletions lib/css/res.scss
Original file line number Diff line number Diff line change
@@ -58,10 +58,7 @@ body.res-console-open {
#console-container {
z-index: $zindex-console-container - 1;
position: fixed;
top: 0;
right: 0;
bottom: 0;
left: 0;
inset: 0 0 0 0;
width: 100%;
height: 100%;
border: none;
@@ -232,10 +229,7 @@ div.usertext-edit {

.toggleThumb {
cursor: pointer;
top: 0;
left: 0;
right: 0;
bottom: 0;
inset: 0 0 0 0;
width: 40px;
height: 15px;
background-color: #ccc;
@@ -459,13 +453,13 @@ span.multi-count {
overflow: auto;
z-index: $zindex-alert-message;

@media (max-width: 520px) {
@media (width <= 520px) {
width: auto;
left: 10px;
right: 10px;
}

@media (max-height: 520px) {
@media (height <= 520px) {
height: auto;
bottom: 10px;
}
@@ -485,10 +479,7 @@ span.multi-count {

#alert_message_background {
position: fixed;
top: 0;
left: 0;
bottom: 0;
right: 0;
inset: 0 0 0 0;
background-color: rgb(0 0 0 / 70%);
z-index: $zindex-alert-message - 1;
}
@@ -593,7 +584,6 @@ span.multi-count {

.builderTrailingControls {
margin-left: auto !important;
~ & { margin-left: initial !important; }

.builderBlock[data-type='group'] + & {
position: absolute; // Avoids the delete button taking vertical space, shriking the recursive block
@@ -690,10 +680,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
content: '';
z-index: 1;
position: absolute;
top: 0;
right: 0;
bottom: 0;
left: 0;
inset: 0 0 0 0;
background-color: #999;
opacity: 0.6;
}
4 changes: 2 additions & 2 deletions lib/modules/filteReddit/postCases/PostAge.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* @flow */

import { dropWhile, head } from 'lodash-es';
import { dropWhile } from 'lodash-es';
import { Case } from '../Case';
import { numericalCompare, prettyOperator, inverseOperator } from '../../../utils';

@@ -25,7 +25,7 @@ export class PostAge extends Case {
let age = parseInt(input, 10);
if (isNaN(age)) throw new Error('Invalid age');

const ageQualifier = head(input.match(/Y|M|d|h|m|s/)) || 's';
const ageQualifier = (input.match(/Y|M|d|h|m|s/)).at(0) || 's';
age = dropWhile(qualifiers, ([qualifier]) => qualifier !== ageQualifier)
.reduce((a, [, multiplier]) => a * multiplier, age);

5 changes: 1 addition & 4 deletions lib/options/options.scss
Original file line number Diff line number Diff line change
@@ -134,10 +134,7 @@ li {
#moduleOptionsScrim {
display: none;
position: absolute;
top: 0;
right: 0;
bottom: 0;
left: 0;
inset: 0 0 0 0;
z-index: 1;
background-color: rgb(255 255 255 / 70%);