Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase margin for sampling distribution test #107

Merged
merged 2 commits into from
Aug 27, 2020

Conversation

katiebayes
Copy link
Contributor

@katiebayes katiebayes commented Aug 26, 2020

This should do the trick for the bounds that is occasionally not met in tests.
For sample_rate of 10, we've been using a margin of 0.05, which tests for samples to be within 250.00 of the 5000 expected. It's occasionally a few outside of that, leading to very occasional build failure.
Bumping to 0.06 will increase the bounds enough that we're still checking sufficiently without running into this break. (5000 * 0.06 == 300)

@katiebayes katiebayes requested review from martin308 and a team August 26, 2020 21:58
Copy link
Member

@martin308 martin308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish we didn't have to do it, but this is better than flaky tests!

@katiebayes katiebayes merged commit 8251255 into honeycombio:main Aug 27, 2020
@katiebayes katiebayes deleted the tweak-test branch August 27, 2020 03:30
@katiebayes katiebayes mentioned this pull request Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants