Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gather up the matrix'd code coverage and save a report #173

Merged
merged 6 commits into from
Sep 20, 2021
Merged

gather up the matrix'd code coverage and save a report #173

merged 6 commits into from
Sep 20, 2021

Conversation

robbkidd
Copy link
Member

Which problem is this PR solving?

  • We removed CodeCov which was what had been aggregating the code coverage reports across the matrix of test jobs. Without aggregating the results, each report looks like things are left without coverage.

Short description of the changes

  • Cache the coverage report for a particular job in a job-named directory, cache those results in the CI workspace, collate the results once all the test jobs are complete, then store the report in the over-all job's artifacts (coverage directory, though, not the artifacts directory).

@robbkidd robbkidd force-pushed the robb.collate-code-coverage-report branch from 10b8fc0 to 34c8eb4 Compare September 17, 2021 18:49
@robbkidd
confirm coverage results are present
7d0c7d5
@robbkidd
need to "run" the ruby command before attaching workspace
df94b1e 
The ruby command includes a checkout action of the repo and must precede
attaching anything to the workspace in CI. So this is a dummy command
to get the ruby step to setup the Ruby environment so that rake can be
run after the coverage results are attached.
@robbkidd
let's only upload the final report
2064cb0
@robbkidd
coverage by component type in report
95fa38a
@robbkidd
Revert "let's only upload the final report"
b86b753 
This reverts commit 2064cb0.
@robbkidd robbkidd marked this pull request as ready for review September 17, 2021 20:30
@robbkidd robbkidd requested a review from martin308 as a code owner September 17, 2021 20:30
@robbkidd robbkidd requested a review from a team September 17, 2021 20:30
@robbkidd robbkidd added type: maintenance The necessary chores to keep the dust off. version: no bump A PR with maintenance or doc changes that aren't included in a release. labels Sep 17, 2021
@robbkidd robbkidd merged commit ffa4d84 into main Sep 20, 2021
@robbkidd robbkidd deleted the robb.collate-code-coverage-report branch September 20, 2021 16:20
@robbkidd
Copy link
Member Author

CI-only changes, so no version bump or release necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeGoldsmith MikeGoldsmith MikeGoldsmith approved these changes

@martin308 martin308 Awaiting requested review from martin308

Assignees
No one assigned
Labels
type: maintenance The necessary chores to keep the dust off. version: no bump A PR with maintenance or doc changes that aren't included in a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robbkidd @MikeGoldsmith