Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add request.header.accept_language field #94

Merged
merged 1 commit into from
Jun 9, 2020
Merged

Add request.header.accept_language field #94

merged 1 commit into from
Jun 9, 2020

Conversation

timcraft
Copy link
Contributor

@timcraft timcraft commented Jun 9, 2020 •
edited
Loading

This would be useful for debugging locale related production issues.

@timcraft timcraft marked this pull request as ready for review June 9, 2020 11:48
@timcraft timcraft mentioned this pull request Jun 9, 2020
Closed
@paulosman paulosman requested a review from martin308 June 9, 2020 12:14
martin308
martin308 approved these changes Jun 9, 2020
View reviewed changes
Copy link
Member

@martin308 martin308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@paulosman paulosman merged commit 70c2274 into honeycombio:master Jun 9, 2020
@timcraft timcraft deleted the add-accept-language-field branch June 10, 2020 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin308 martin308 martin308 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timcraft @martin308 @paulosman