Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Record sample rate for kept traces during stress relief #1271

Closed
VinozzZ opened this issue Aug 14, 2024 · 0 comments · Fixed by #1273
Closed

Record sample rate for kept traces during stress relief #1271

VinozzZ opened this issue Aug 14, 2024 · 0 comments · Fixed by #1273
Assignees
@VinozzZ
Labels
type: bug Something isn't working
Milestone
v2.8

Comments

@VinozzZ
Copy link
Contributor

VinozzZ commented Aug 14, 2024

SampleRate calculated during stress relief should be recorded in the decision cache. This will keep the sample rate consistent between each spans that belongs to the same trace.
@VinozzZ VinozzZ added the type: bug Something isn't working label Aug 14, 2024
@VinozzZ VinozzZ added this to the v2.8 milestone Aug 14, 2024
@VinozzZ VinozzZ self-assigned this Aug 14, 2024
@VinozzZ VinozzZ mentioned this issue Aug 14, 2024
Merged
VinozzZ added a commit that referenced this issue Aug 14, 2024
@VinozzZ
fix: record sample rate in decision cache during stress relief (#1273)
039babc 
<!--
Thank you for contributing to the project! 💜
Please make sure to:
- Chat with us first if this is a big change
  - Open a new issue (or comment on an existing one)
- We want to make sure you don't spend time implementing something we
might have to say No to
- Add unit tests
- Mention any relevant issues in the PR description (e.g. "Fixes #123")

Please see our [OSS process
document](https://github.com/honeycombio/home/blob/main/honeycomb-oss-lifecycle-and-practices.md#)
to get an idea of how we operate.
-->

## Which problem is this PR solving?

Sample rate is not recorded in trace decision cache during stress
relief. This could cause weird sample rate data for spans arrived after
refinery has exited stress relief mode
fix: #1271 

## Short description of the changes

- record sample rate in decision cache
- add tests
- make sure collector uses clockwork.Clock in all places
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VinozzZ VinozzZ

Labels
type: bug Something isn't working
Projects
None yet
Milestone
v2.8
Development

Successfully merging a pull request may close this issue.

fix: record sample rate in decision cache during stress relief honeycombio/refinery
1 participant
@VinozzZ