fix: Clean up all the things, even if redis doesn't know about it #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeGoldsmith
approved these changes
May 23, 2024
VinozzZ
approved these changes
May 23, 2024
tdarwin
pushed a commit
to tdarwin/refinery
that referenced
this pull request
Jun 26, 2024
…neycombio#1167) ## Which problem is this PR solving? - We saw refinery seemed to lose track of some traces and just leave them in the cache forever. This makes sure they can't hang around forever, and we'll track a metric for it ## Short description of the changes - Add CleanupCycleDuration config value - Use it for the cleanup cycle - Drop traces we can't find in redis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes