Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Change pubsub interface to use callbacks. #1217

Merged
merged 6 commits into from
Jul 2, 2024
Merged

fix: Change pubsub interface to use callbacks. #1217

merged 6 commits into from
Jul 2, 2024

Conversation

kentquirk
Copy link
Contributor

Which problem is this PR solving?

  • The channel-based pubsub interface is really hard to reason about and it's difficult to shut down without race conditions.

Short description of the changes

  • Change to a callback model
  • Rewrite the tests and benchmarks

@kentquirk kentquirk requested a review from a team as a code owner July 1, 2024 20:04
VinozzZ
VinozzZ reviewed Jul 1, 2024
View reviewed changes
pubsub/pubsub_local.go Outdated Show resolved Hide resolved
pubsub/pubsub_local.go Show resolved Hide resolved
pubsub/pubsub_test.go Outdated Show resolved Hide resolved
pubsub/pubsub_goredis.go Outdated Show resolved Hide resolved
pubsub/pubsub_goredis.go Show resolved Hide resolved
@kentquirk kentquirk self-assigned this Jul 1, 2024
@kentquirk kentquirk added this to the v2.7 milestone Jul 1, 2024
@kentquirk kentquirk merged commit a19e3f9 into main Jul 2, 2024
3 checks passed
@kentquirk kentquirk deleted the kent.pubsub_fix branch July 2, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VinozzZ VinozzZ VinozzZ approved these changes

Assignees

@kentquirk kentquirk

Labels
None yet
Projects
None yet
Milestone
v2.7
Development

Successfully merging this pull request may close these issues.
2 participants
@kentquirk @VinozzZ