Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use pub/sub for stress relief #1221

Merged
merged 10 commits into from
Jul 23, 2024
Merged

Conversation

VinozzZ
Copy link
Contributor

@VinozzZ VinozzZ commented Jul 3, 2024

Which problem is this PR solving?

Enable stress relief management for Refinery cluster as a whole rather than only for individual instances.

Short description of the changes

  • broadcast individual stress level through pub/sub to other peers
  • calculate cluster stress level when individual cluster level changes or on a timer
  • during stress relief, deterministic sampling for a portion of traces based on current cluster stress level
  • add tests

@VinozzZ VinozzZ requested a review from a team as a code owner July 3, 2024 20:41
@VinozzZ VinozzZ self-assigned this Jul 3, 2024
@VinozzZ VinozzZ added the type: enhancement New feature or request label Jul 3, 2024
@VinozzZ VinozzZ added this to the v2.7 milestone Jul 3, 2024
@VinozzZ VinozzZ force-pushed the yingrong.stress_relief_gossip branch from 185c97b to d55be52 Compare July 22, 2024 15:37
collect/stressRelief.go Fixed Show resolved Hide resolved
Copy link
Contributor

@kentquirk kentquirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't had time to finish my review but I have a meeting, so here are some things to get started on; more later.

collect/collect.go Show resolved Hide resolved
collect/stressRelief.go Outdated Show resolved Hide resolved
collect/stressRelief.go Outdated Show resolved Hide resolved
collect/stressRelief.go Outdated Show resolved Hide resolved
collect/stressRelief.go Outdated Show resolved Hide resolved
collect/stressRelief.go Outdated Show resolved Hide resolved
collect/stressRelief.go Show resolved Hide resolved
collect/stressRelief.go Outdated Show resolved Hide resolved
Copy link
Contributor

@kentquirk kentquirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

@VinozzZ VinozzZ merged commit 8c96628 into main Jul 23, 2024
5 checks passed
@VinozzZ VinozzZ deleted the yingrong.stress_relief_gossip branch July 23, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants