Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sharder should use peer identity from Peers package #1249

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

VinozzZ
Copy link
Contributor

@VinozzZ VinozzZ commented Jul 25, 2024

Which problem is this PR solving?

DeterministicSharder wasn't updated to use the new peer identification system to determine which peer a given trace belongs to. This resulted Refinery couldn't identify itself in the peer list within the sharding system.

Short description of the changes

  • Consolidate and unify code for retrieving peer identity
  • replace : with | as the delimiter in stress relief message
  • make sure filepeer returns PeerListenAddr as its public address

@VinozzZ VinozzZ marked this pull request as ready for review July 25, 2024 01:16
@VinozzZ VinozzZ requested a review from a team as a code owner July 25, 2024 01:16
@VinozzZ VinozzZ added this to the v2.7 milestone Jul 25, 2024
Copy link
Contributor

@kentquirk kentquirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks fine. I am realizing, though, that FilePeers is now almost pointless, because its main reason for existing for more than one node is so that someone can avoid running Redis. But now we depend on Redis for more than just peers, so even if you do FilePeers you still have to do Redis.

@VinozzZ
Copy link
Contributor Author

VinozzZ commented Jul 25, 2024

I think this looks fine. I am realizing, though, that FilePeers is now almost pointless, because its main reason for existing for more than one node is so that someone can avoid running Redis. But now we depend on Redis for more than just peers, so even if you do FilePeers you still have to do Redis.

The other place that depends on Redis is stress relief and configs. Using filepeer means, peers will act independently in both stress relief and config change system. Essentially, if a Refinery cluster is using filepeer, they won't get much benefit from this release. We can document it, but at least it's not breaking existing behavior.

@VinozzZ VinozzZ merged commit 255a6a3 into main Jul 25, 2024
6 checks passed
@VinozzZ VinozzZ deleted the yingrong.fix_sharding branch July 25, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants