feat: allow root. in field list for dynamic sampler #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eycombio/refinery into yingrong.root_prefix_dynamic_sampler
MikeGoldsmith
pushed a commit
that referenced
this pull request
Oct 23, 2024
…#1396) ## Short description of the changes - This PR documents the feature from #1275, showing our users how to specify the `root.` prefix in FieldLists everywhere - It also sprinkles the use of this feature around the `rules_complete.yaml` example Signed-off-by: Irving Popovetsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
To reduce the cardinality in sampler keys for dynamic sampler in Refinery, it's helpful to be able to only select fields on root spans.
fixes #1130
Short description of the changes
root.in field listtraceKey