Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow draining traces even if only 1 peer left #1278

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

VinozzZ
Copy link
Contributor

@VinozzZ VinozzZ commented Aug 15, 2024

Which problem is this PR solving?

When in peer mode, there could be a situation that the load is low enough for just one refinery instance. We should allow a scale down event to happen even if there's only one refinery left

Short description of the changes

  • change the condition to run redistribution logic to as long as there's 1 peer in the peer list
  • add trace_redistribution_count metric to track how often a redistribution event has been triggered.

@VinozzZ VinozzZ requested a review from a team as a code owner August 15, 2024 19:04
@VinozzZ VinozzZ force-pushed the yingrong.fix_draining_condition branch from f566ee0 to 26dbbe5 Compare August 15, 2024 19:05
@VinozzZ VinozzZ added this to the v2.8 milestone Aug 15, 2024
Copy link
Contributor

@kentquirk kentquirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@VinozzZ VinozzZ merged commit d147025 into main Aug 15, 2024
5 checks passed
@VinozzZ VinozzZ deleted the yingrong.fix_draining_condition branch August 15, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants