Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: change default for MaxSendMsgSize and MaxRcvMsgSize. #1289

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

kentquirk
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Change the defaults from 5MB to 15MB
  • This is technically a breaking change but only by the most pedantic definition -- there's no realistic situation in which this actually matters, so we're not going to stress over it.

@kentquirk kentquirk requested a review from a team as a code owner August 19, 2024 15:00
@tdarwin
Copy link
Contributor

tdarwin commented Aug 19, 2024

rugby-yay

Copy link
Contributor

@VinozzZ VinozzZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also change the default value in the file_config.go file so that they are consistent

@kentquirk kentquirk requested a review from VinozzZ August 19, 2024 15:32
@kentquirk kentquirk merged commit faa1375 into main Aug 19, 2024
5 checks passed
@kentquirk kentquirk deleted the kent.rcvmsgsize2 branch August 19, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discussion: Raising the max receive message size default for GRPC connections?
3 participants