Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: add a docker'd Redis TLS local setup #1291

Merged
merged 5 commits into from
Aug 21, 2024

Conversation

robbkidd
Copy link
Member

Which problem is this PR solving?

  • make it easy to run a TLS'd Redis locally in development
  • maybe a foundation for smoke-tests later

Short description of the changes

  • add a make target for building the Docker image locally like CI does for releases
  • add a docker-compose config in a new smoke-tests/ directory
    • redis is run with TLS enabled using self-signed certs generated as needed by the gen-certs service container

@robbkidd robbkidd force-pushed the robb.smokey-dockerz-with-tls branch from 5de470d to ec8abf9 Compare August 19, 2024 17:12
@kentquirk
Copy link
Contributor

I know this is still in draft, but please add a README to the folder explaining how to use it?

@robbkidd robbkidd force-pushed the robb.smokey-dockerz-with-tls branch from a9735fe to e97f631 Compare August 20, 2024 15:01
More troubleshooting deets.
@robbkidd robbkidd self-assigned this Aug 20, 2024
@robbkidd robbkidd marked this pull request as ready for review August 20, 2024 20:14
@robbkidd robbkidd requested a review from a team as a code owner August 20, 2024 20:14
@robbkidd robbkidd added version: no bump A PR with maintenance or doc changes that aren't included in a release. no-changelog Omit this PR from changelog/release notes. labels Aug 20, 2024
smoke-test/config.yaml Outdated Show resolved Hide resolved
smoke-test/config.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@VinozzZ VinozzZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this on my machine and it works great

@robbkidd robbkidd merged commit 0f7f6f5 into main Aug 21, 2024
5 checks passed
@robbkidd robbkidd deleted the robb.smokey-dockerz-with-tls branch August 21, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Omit this PR from changelog/release notes. version: no bump A PR with maintenance or doc changes that aren't included in a release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants