Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support configure refinery to use redis in cluster mode #1294

Merged
merged 7 commits into from
Aug 22, 2024
Merged

feat: support configure refinery to use redis in cluster mode #1294

merged 7 commits into from
Aug 22, 2024

Conversation

VinozzZ
Copy link
Contributor

@VinozzZ VinozzZ commented Aug 21, 2024 •
edited
Loading

Which problem is this PR solving?

To support Redis instances in cluster mode, we need to provide a way for users to configure Refinery accordingly.
fixes #1286

Short description of the changes

  • Add a new config option, ClusterHosts, under RedisPeerManagement
  • Consolidate RedisPeerManagementConfig getters into one
  • Add support for env-delim:"," in CmdEnv
  • Add tests

@VinozzZ VinozzZ requested a review from a team as a code owner August 21, 2024 14:54
@VinozzZ VinozzZ changed the title Yingrong.redis cluster feat: support configure refinery to use redis in cluster mode Aug 21, 2024
kentquirk
kentquirk reviewed Aug 21, 2024
View reviewed changes
Copy link
Contributor

@kentquirk kentquirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is quite enough to work with AWS. We need to use the Cluster client if ClusterHosts is specified, because with AWS there will only be one host.

config/metadata/configMeta.yaml Outdated Show resolved Hide resolved
config/mock.go Outdated Show resolved Hide resolved
@VinozzZ VinozzZ requested a review from kentquirk August 21, 2024 16:05
robbkidd
robbkidd reviewed Aug 21, 2024
View reviewed changes
config/file_config.go Outdated Show resolved Hide resolved
kentquirk
kentquirk approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@kentquirk kentquirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this better! Thanks for making the changes.

@VinozzZ VinozzZ merged commit 2cc0574 into main Aug 22, 2024
5 checks passed
@VinozzZ VinozzZ deleted the yingrong.redis_cluster branch August 22, 2024 19:02
@VinozzZ VinozzZ added this to the v2.8 milestone Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbkidd robbkidd robbkidd left review comments

@kentquirk kentquirk kentquirk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.8
Development

Successfully merging this pull request may close these issues.

Support Redis cluster mode
3 participants
@VinozzZ @robbkidd @kentquirk