Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: Add some extra logging to pubsub systems #1308

Merged
merged 4 commits into from
Sep 4, 2024
Merged

Conversation

kentquirk
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Add some logging in pubsub
  • Delete an unused function

@kentquirk kentquirk requested a review from a team as a code owner September 3, 2024 22:03
Copy link
Member

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to also dump (maybe with a flag?) the config and rules config to stdout on startup? This would help field teams a bunch.

@kentquirk
Copy link
Contributor Author

We have the ability to query the config through an endpoint if you specify the debug flag.

What you ask for is possible, but how/why is it different than reading the config files directly? Those are also specified on the command line.

@cartermp
Copy link
Member

cartermp commented Sep 3, 2024

In a chat with @irvingpop he mentioned that it's often a struggle to get the actual config/rules used in a given refinery run, and there's more hopping back and forth with "wait, this doesn't match what you're saying, are you sure this is right?" than they'd like. @irvingpop is that a fair assessment?

Copy link
Contributor

@VinozzZ VinozzZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The test failed in CI is due to missing logger initialization in pubsub test data

@kentquirk kentquirk requested a review from VinozzZ September 4, 2024 14:31
@kentquirk kentquirk merged commit 34734d2 into main Sep 4, 2024
5 checks passed
@kentquirk kentquirk deleted the kent.diagnostics branch September 4, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a lot more diagnostics during startup before Refinery is running.
3 participants