Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow SendKey to be set via command line and env var #1323

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

MikeGoldsmith
Copy link
Contributor

Which problem is this PR solving?

Adds support for setting the send key (API key) used to send data to Honeycomb via both command line and env var.

Short description of the changes

  • Add support for setting AccessKeys.SendKey via command line arg --send-key or env var REFINERY_SEND_KEY.
  • Add unit tests to verify behaviour

@MikeGoldsmith MikeGoldsmith added the type: enhancement New feature or request label Sep 12, 2024
@MikeGoldsmith MikeGoldsmith self-assigned this Sep 12, 2024
@MikeGoldsmith MikeGoldsmith requested a review from a team as a code owner September 12, 2024 14:36
@MikeGoldsmith MikeGoldsmith added this to the v2.9 milestone Sep 12, 2024
config/config_test.go Outdated Show resolved Hide resolved
config/config_test.go Outdated Show resolved Hide resolved
@MikeGoldsmith MikeGoldsmith merged commit f4ca704 into main Sep 13, 2024
5 checks passed
@MikeGoldsmith MikeGoldsmith deleted the mike/sendkey-cmdline branch September 13, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SendKey isn't settable through envvar or cmdline
2 participants