Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: assertion for ClusterSizer #1329

Merged
merged 2 commits into from
Sep 13, 2024
Merged

fix: assertion for ClusterSizer #1329

merged 2 commits into from
Sep 13, 2024

Conversation

VinozzZ
Copy link
Contributor

@VinozzZ VinozzZ commented Sep 13, 2024 •
edited by MikeGoldsmith
Loading

Which problem is this PR solving?

  • ClusterSize was not properly set for samplers that supports UseClusterSize

Short description of the changes

  • implement ClusterSizer for rules sampler
  • convert a Sampler to ClusterSizer by going through any

@VinozzZ VinozzZ requested a review from a team as a code owner September 13, 2024 17:40
@VinozzZ VinozzZ added the type: bug Something isn't working label Sep 13, 2024
@VinozzZ VinozzZ added this to the v2.9 milestone Sep 13, 2024
kentquirk
kentquirk approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@kentquirk kentquirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tricky one!

@VinozzZ VinozzZ merged commit aeea1d4 into main Sep 13, 2024
6 checks passed
@VinozzZ VinozzZ deleted the fix_use_cluser_size branch September 13, 2024 18:19
@VinozzZ VinozzZ mentioned this pull request Sep 16, 2024
Merged
VinozzZ added a commit that referenced this pull request Sep 16, 2024
@VinozzZ
fix: remove unnecessary assertion to any (#1333)
84103fc 
## Which problem is this PR solving?

- in #1329 , we introduced the assertion to `any` as the intermediate
step to check whether a Sampler is a ClusterSizer.
- It turns out that this intermediate step is unnecessary.

## Short description of the changes

- remove assertion to `any` in `SetClusterSize`
TylerHelmuth pushed a commit that referenced this pull request Oct 16, 2024
@VinozzZ @TylerHelmuth
fix: remove unnecessary assertion to any (#1333)
19d24ee 
## Which problem is this PR solving?

- in #1329 , we introduced the assertion to `any` as the intermediate
step to check whether a Sampler is a ClusterSizer.
- It turns out that this intermediate step is unnecessary.

## Short description of the changes

- remove assertion to `any` in `SetClusterSize`
@akvanhar akvanhar removed this from the v2.9 milestone Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentquirk kentquirk kentquirk approved these changes

Assignees
No one assigned
Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VinozzZ @kentquirk @akvanhar