fix: Use peer transmission during redistribute and shutdown events #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
pushed a commit
that referenced
this pull request
Oct 16, 2024
…1332) ## Which problem is this PR solving? Updates the collector use the configured peer transmission to send spans to peers during redistribute and shutdown events. This ensures metrics for sending to Honeycomb and peers are accurate. The peer transmission is already configured and used by the router when receiving spans that should be sent to a peer. This is used the same transmission object after a span was originally accepted but then should be forwarded to a peer. - Closes #1324 ## Short description of the changes - Inject the already configured peer transmission during collector init - Update redistribute and shutdown logic to use the peer transmission - Update tests throughout to verify the peer transmission is used correctly and also verify it can be injected correctly - note: there were existing tests to verify redistribute and shutdown behaviour and have been updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Updates the collector use the configured peer transmission to send spans to peers during redistribute and shutdown events. This ensures metrics for sending to Honeycomb and peers are accurate.
The peer transmission is already configured and used by the router when receiving spans that should be sent to a peer. This is used the same transmission object after a span was originally accepted but then should be forwarded to a peer.
Short description of the changes