feat: make collector health check timeout configurable #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinozzZ
force-pushed
the
yingrong.make_collect_healthcheck_configurable
branch
from
9507863 to
656ee72
Compare
TylerHelmuth
approved these changes
Oct 10, 2024
|
I'd also suggest updating the target branch to main, then we can cherry-pick it back into the release branch. |
VinozzZ
force-pushed
the
yingrong.make_collect_healthcheck_configurable
branch
from
cc6c60c to
752475c
Compare
MikeGoldsmith
approved these changes
Oct 10, 2024
MikeGoldsmith
pushed a commit
that referenced
this pull request
Oct 10, 2024
## Which problem is this PR solving? When there's a big volume of traffic, collector can take longer to respond to the health check ## Short description of the changes - add a new config option `HealthCheckTimeout` in `Collection` --------- Co-authored-by: Tyler Helmuth <[email protected]> # Conflicts: # config/metadata/configMeta.yaml
TylerHelmuth
added a commit
that referenced
this pull request
Oct 16, 2024
When there's a big volume of traffic, collector can take longer to respond to the health check - add a new config option `HealthCheckTimeout` in `Collection` --------- Co-authored-by: Tyler Helmuth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
When there's a big volume of traffic, collector can take longer to respond to the health check
Short description of the changes
HealthCheckTimeoutinCollection