maint: cherry pick v2.8.4 commits into main. #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gram (#1381) ## Which problem is this PR solving? - Recording the value as a guage meant that a lot of values were missed as the older values got overwritten by newer values. This meant the largest value in the interval may not get exported. ## Short description of the changes - Switch `collector_collect_loop_duration_ms` from gauge to histogram to make sure max values are captured.
## Which problem is this PR solving? - prep 2.8.4 release ## Short description of the changes - run `make all` (we forgot to do this on the 2.8.3-release branch). - update changelog - update release notes
VinozzZ
approved these changes
Oct 11, 2024
TylerHelmuth
added a commit
that referenced
this pull request
Oct 16, 2024
- gets the changes from 2.8.4 into main - update `collector_collect_loop_duration_ms` type - run `make all` - get 2.8.4 changelog and release notes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
collector_collect_loop_duration_mstypemake all