fix: reset redistribution delay on peer membership change #1403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentquirk
reviewed
Oct 30, 2024
There was a problem hiding this comment.
I believe this is correct, but I added some more comments because I've already forgotten the details from when we talked about this a while back. If I'm not correct, please fix it. I think this is one of those things that probably can't have enough explanation.
|
@kentquirk That sounds correct to me! Thanks for adding the comments |
Co-authored-by: Kent Quirk <[email protected]>
MikeGoldsmith
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
redistributeNotifierto its own file sincecollect.gois getting bigtriggeredchannel whentimerfirestimerwhen receiving a peer membership change fromr.reset