fix: deal with orphan traces in trace cache #1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
approved these changes
Oct 31, 2024
Comment on lines
+641
to
+646
| i.PeerTransmission.EnqueueEvent(i.createDecisionSpan(&types.Span{ | ||
| TraceID: trace.ID(), | ||
| Event: types.Event{ | ||
| Context: trace.GetSpans()[0].Context, | ||
| }, | ||
| }, trace, i.Sharder.WhichShard(trace.ID()))) |
There was a problem hiding this comment.
I'm curious what impact this will have on network traffic.
There was a problem hiding this comment.
This should be an edge case and we are essentially just sending a trace id. Hopefully it won't have too big of an impact
kentquirk
approved these changes
Oct 31, 2024
collect/collect.go
Outdated
| if !i.IsMyTrace(trace.ID()) { | ||
| err := errors.New("cannot make a decision for partial traces") | ||
|
|
||
| i.Logger.Warn().WithFields(map[string]interface{}{ |
There was a problem hiding this comment.
Isn't this really common? Do we actually want to be sending thousands of copies of this warning?
If we keep it, I think the error message could be clearer (what kind of decision are we trying to make?).
And finally, it's a constant string -- why construct an error out of it, and then convert it back to a string?
There was a problem hiding this comment.
I agree with you concern. I changed the log level to debug and the message to be more specific
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
If for some reason, a trace that doesn't belong to a peer in the trace cache missed its trace decision from its decider, it will stay in the cache forever.
This PR introduce a clean up mechanism for the scenario above.
Short description of the changes
filterfunction insendExpiredTracesto also return traces that have expired for too longsendExpiredTracesbehavior