feat: Add a way to specify the team key for config fetches (experimental) #1410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
To fetch a configuration from Honeycomb, we're going to need a way to specify a header for the team key. This allows the key to be specified in an environment variable called
HONEYCOMB_CONFIG_KEY. This is deliberately different from the telemetry key because the key will have to have special permissions.If the key is not blank, then the header
x-honeycomb-teamwill be set and used for the config requests. The header will not be used if the key is blank.We are deliberately not adding this to public documentation because this feature is still experimental and we may well change it.
Short description of the changes
HONEYCOMB_CONFIG_KEYfrom the environmentx-honeycomb-teamheader if the key is non-blank.