Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: only redistribute traces when its ownership has changed #1411

Merged
merged 6 commits into from
Nov 7, 2024

Conversation

VinozzZ
Copy link
Contributor

@VinozzZ VinozzZ commented Nov 6, 2024

Which problem is this PR solving?

To reduce the amount of traffic produced during a redistribution event, this PR changes the logic to only redistribute traces that has its ownership changed

Short description of the changes

  • update redistributeTraces to only forward data when a trace's ownership has changed
  • make redistribution delay configurable
  • add tests

@VinozzZ VinozzZ requested a review from a team as a code owner November 6, 2024 21:46
Copy link
Contributor

@kentquirk kentquirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I tweaked the docs a bit.

config/metadata/configMeta.yaml Outdated Show resolved Hide resolved
@VinozzZ VinozzZ merged commit d6948ba into main Nov 7, 2024
5 checks passed
@VinozzZ VinozzZ deleted the yingrong/redistribute_only_moved_traces branch November 7, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants