Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: send kept trace decision in a separate goroutine #1412

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

VinozzZ
Copy link
Contributor

@VinozzZ VinozzZ commented Nov 6, 2024

Which problem is this PR solving?

To reduce ingest latency, moving the work for publishing kept trace decisions into a separate goroutine so it doesn't block ingest incoming data.

This code has been running in kibble for a few days and it's copied from the debug branch #1408

Short description of the changes

  • create a buffer for kept trace decision
  • make publishing kept trace decision non-blocking in the collect loop

@VinozzZ VinozzZ added the type: enhancement New feature or request label Nov 6, 2024
@VinozzZ VinozzZ added this to the v2.9 milestone Nov 6, 2024
@VinozzZ VinozzZ self-assigned this Nov 6, 2024
@VinozzZ VinozzZ requested a review from a team as a code owner November 6, 2024 22:39
@MikeGoldsmith MikeGoldsmith merged commit fe442a3 into main Nov 7, 2024
7 checks passed
@MikeGoldsmith MikeGoldsmith deleted the yingrong/send_kept_decision_in_a_goroutine branch November 7, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants