Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: send all traffic through deterministic sampler during stress relief activated #1433

Merged
merged 2 commits into from
Nov 18, 2024
Merged

fix: send all traffic through deterministic sampler during stress relief activated #1433

merged 2 commits into from
Nov 18, 2024

Conversation

VinozzZ
Copy link
Contributor

@VinozzZ VinozzZ commented Nov 15, 2024

Which problem is this PR solving?

Short description of the changes

  • remove logic for sending fraction of all traffic through normal operation during stress

@VinozzZ VinozzZ requested a review from a team as a code owner November 15, 2024 20:42
@VinozzZ VinozzZ self-assigned this Nov 15, 2024
@VinozzZ VinozzZ added the type: enhancement New feature or request label Nov 15, 2024
@VinozzZ VinozzZ added this to the v2.9 milestone Nov 15, 2024
@MikeGoldsmith MikeGoldsmith merged commit 14cc28a into main Nov 18, 2024
5 checks passed
@MikeGoldsmith MikeGoldsmith deleted the yingrong/use_deterministic_sampler_for_all_traffic_during_stress branch November 18, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeGoldsmith MikeGoldsmith MikeGoldsmith approved these changes

Assignees

@VinozzZ VinozzZ

Labels
type: enhancement New feature or request
Projects
None yet
Milestone
v2.9
Development

Successfully merging this pull request may close these issues.

Sample ratio not align with configured SampleRate during Stress Relief
2 participants
@VinozzZ @MikeGoldsmith