Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure span links and events generate events and get resource attrs #264

Merged
merged 7 commits into from
Jun 25, 2021
Merged

Ensure span links and events generate events and get resource attrs #264

merged 7 commits into from
Jun 25, 2021

Conversation

MikeGoldsmith
Copy link
Contributor

@MikeGoldsmith MikeGoldsmith commented Jun 3, 2021 •
edited
Loading

When generating events for OTLP span events and links, each sub-event should also get resource attributes added.

NOTE:

  • Fixed a couple of linter warnings in 258cf31
  • Testing event content is challenging because if the number of dependencies required, collector, metrics, sampler. I've tested the events are created as expected but fixing testing framework is larger task

cc @bdarfler

@MikeGoldsmith MikeGoldsmith requested review from dstrelau and a team June 3, 2021 15:46
dstrelau
dstrelau reviewed Jun 3, 2021
View reviewed changes
route/route.go Outdated Show resolved Hide resolved
@MikeGoldsmith MikeGoldsmith self-assigned this Jun 7, 2021
@dstrelau dstrelau linked an issue Jun 8, 2021 that may be closed by this pull request
Span Links from OTLP are dropped #268
Closed
@MikeGoldsmith MikeGoldsmith requested review from dstrelau and a team June 9, 2021 19:20
paulosman
paulosman approved these changes Jun 22, 2021
View reviewed changes
Copy link

@paulosman paulosman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MikeGoldsmith MikeGoldsmith merged commit a868497 into main Jun 25, 2021
@MikeGoldsmith MikeGoldsmith deleted the mike/span-event-links-attrs branch June 25, 2021 08:54
ghost pushed a commit to opsramp/tracing-proxy that referenced this pull request Jul 5, 2024
@MikeGoldsmith
Ensure span links and events generate events and get resource attrs (h…
8179634 
…oneycombio#264)

When generating events for OTLP span events and links, each sub-event should also get resource attributes added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdarfler bdarfler bdarfler left review comments

@paulosman paulosman paulosman approved these changes

@dstrelau dstrelau Awaiting requested review from dstrelau

Assignees

@MikeGoldsmith MikeGoldsmith

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Span Links from OTLP are dropped
4 participants
@MikeGoldsmith @dstrelau @paulosman @bdarfler