Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump husky to v0.4.0 #361

Merged
merged 3 commits into from
Dec 6, 2021
Merged

Bump husky to v0.4.0 #361

merged 3 commits into from
Dec 6, 2021

Conversation

MikeGoldsmith
Copy link
Contributor

@MikeGoldsmith MikeGoldsmith commented Dec 2, 2021

Which problem is this PR solving?

Updates the Husky to v0.3.0 and removes duplicate code Husky now provides.

Short description of the changes

  • Bump husky to v0.4.0 (includes downgrading otlp to v0.9.0)
  • Update otlp_trace to use new interface
  • Remove getSampleRateFromAttributes func and tests

@MikeGoldsmith MikeGoldsmith added version: bump patch A PR with release-worthy changes and is backwards-compatible. type: maintenance The necessary chores to keep the dust off. labels Dec 2, 2021
@MikeGoldsmith MikeGoldsmith self-assigned this Dec 2, 2021
@MikeGoldsmith MikeGoldsmith requested a review from a team December 2, 2021 10:38
Copy link
Member

@robbkidd robbkidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

I think it's safe to merge this even though we have a pending decision around which version of otel-proto-go to depend on in husky as a result of the transitive dep on grpc brining in surprising changes in other husky-using projects. Refinery can benefit from this change on main and get an updated husky (with back-versioned proto-go and grpc) as a followup.

a husky poking its head in

@MikeGoldsmith
Copy link
Contributor Author

MikeGoldsmith commented Dec 3, 2021

I'll hold on this and bump to v0.4.0 instead so not have to mess around go.mod go.sum twice 😢

@MikeGoldsmith MikeGoldsmith changed the title Bump husky to v0.3.0 Bump husky to v0.4.0 Dec 6, 2021
@MikeGoldsmith MikeGoldsmith merged commit 0d77d0f into main Dec 6, 2021
@MikeGoldsmith MikeGoldsmith deleted the mike/bump-husky branch December 6, 2021 15:44
ghost pushed a commit to opsramp/tracing-proxy that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance The necessary chores to keep the dust off. version: bump patch A PR with release-worthy changes and is backwards-compatible.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants