Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added username in config for redis auth #397

Merged
merged 1 commit into from
Feb 10, 2022
Merged

added username in config for redis auth #397

merged 1 commit into from
Feb 10, 2022

Conversation

ecobrien29
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Adds optional username field in the config file for authenticating with redis. I tested this on my refinery instance connected to aws' redis memorydb

@ecobrien29 ecobrien29 requested a review from a team February 9, 2022 21:16
vreynolds
vreynolds approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@vreynolds vreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@vreynolds vreynolds added type: enhancement New feature or request version: bump minor A PR that adds behavior, but is backwards-compatible. labels Feb 10, 2022
@vreynolds vreynolds merged commit ff978ce into honeycombio:main Feb 10, 2022
@vreynolds vreynolds mentioned this pull request Feb 10, 2022
Closed
ghost pushed a commit to opsramp/tracing-proxy that referenced this pull request Jul 5, 2024
@ecobrien29
added username in config for redis auth (honeycombio#397)
2ce96b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vreynolds vreynolds vreynolds approved these changes

Assignees
No one assigned
Labels
type: enhancement New feature or request version: bump minor A PR that adds behavior, but is backwards-compatible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ecobrien29 @vreynolds