fix: change sample key to not include args in honeycomb logger #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentquirk
approved these changes
Nov 2, 2023
|
I actually think the word "pervasively" makes more sense in this context. |
fchikwekwe
approved these changes
Nov 2, 2023
|
Hahaha, autocorrect definitely gave it more thought than me. My intention is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Previously, Honeycomb logger uses the entire log message as the sampling key. If a log message contains high-cardinality fields, the throttle mechanism will no longer work.
Short description of the changes
This PR changes the key used for sampling from the entire log message to only use the format string