Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add matches operator to rules #939

Merged
merged 2 commits into from
Dec 11, 2023
Merged

feat: Add matches operator to rules #939

merged 2 commits into from
Dec 11, 2023

Conversation

kentquirk
Copy link
Contributor

@kentquirk kentquirk commented Dec 8, 2023

Which problem is this PR solving?

  • Adds a regular expression matches operator to rules which should make some rules easier to write, especially when dealing with URLs or complex string fields.

Short description of the changes

  • Add matches operator
  • Remove some unused switch cases from conditionMatchesOperator (to avoid implementing another one)
  • Add tests for it

This is part of #822.

This one will need further documentation, but that will be addressed in a separate PR.

@kentquirk kentquirk requested a review from a team as a code owner December 8, 2023 19:31
@kentquirk kentquirk force-pushed the kent.matches_operator branch 2 times, most recently from a2dc518 to 5c71e7c Compare December 11, 2023 15:10
Copy link
Contributor

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @kentquirk 👍🏻

@kentquirk kentquirk force-pushed the kent.matches_operator branch from 5c71e7c to 93bb3c1 Compare December 11, 2023 17:07
@kentquirk kentquirk merged commit 0ca0260 into main Dec 11, 2023
3 checks passed
@kentquirk kentquirk deleted the kent.matches_operator branch December 11, 2023 17:46
@kentquirk kentquirk mentioned this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants