-
-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(websocket): Add generics type to WSContext
#3337
Conversation
upgradeWebSocket
WSContext
WSContext
WSContext
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3337 +/- ##
==========================================
- Coverage 96.32% 95.76% -0.56%
==========================================
Files 151 151
Lines 15385 9166 -6219
Branches 2687 2809 +122
==========================================
- Hits 14819 8778 -6041
+ Misses 566 388 -178 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hi @hayatosc ! It looks good. I'm wondering if we should include this feature in the next patch or minor release. After I decide, I'll merge it. Thank you for your contribution! |
Fix #3327
Description
In this pull request, you can set
ws.raw
type asServerWebSocket
on Bun.So, you can now use Bun own WebSocket API, including Pub/Sub feature!
The author should do the following, if applicable
bun run format:fix && bun run lint:fix
to format the code