Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contextStorage): added Context Storage Middleware #3373

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

marceloverdijk
Copy link
Contributor

Supersedes #3335

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.76%. Comparing base (3500404) to head (e1aae26).
Report is 7 commits behind head on next.

Files with missing lines Patch % Lines
src/middleware/context-storage/index.ts 86.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3373      +/-   ##
==========================================
- Coverage   95.77%   95.76%   -0.02%     
==========================================
  Files         152      153       +1     
  Lines        9187     9202      +15     
  Branches     2818     2687     -131     
==========================================
+ Hits         8799     8812      +13     
- Misses        388      390       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe yusukebe changed the base branch from main to next September 8, 2024 06:52
@yusukebe yusukebe merged commit fdf7786 into honojs:next Sep 8, 2024
14 checks passed
@yusukebe yusukebe mentioned this pull request Sep 11, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants