Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@hono/vite-dev-server] feat: use vite runtime API #129

Merged
merged 4 commits into from
Apr 25, 2024

Conversation

alessandrojcm
Copy link
Contributor

Closes #124

Copy link

changeset-bot bot commented Apr 25, 2024

🦋 Changeset detected

Latest commit: 24fe0f5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hono/vite-dev-server Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yusukebe
Copy link
Member

Hi @alessandrojcm

Can you run yarn changeset on the top-level directory to add a changeset? It will be a minor change.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

@alessandrojcm

I've tried the dev-server in this PR, it works well. Looks good! Mergin now. Thanks!

@yusukebe yusukebe merged commit b4019f0 into honojs:main Apr 25, 2024
2 checks passed
@github-actions github-actions bot mentioned this pull request Apr 25, 2024
yusukebe added a commit that referenced this pull request May 10, 2024
yusukebe added a commit that referenced this pull request May 10, 2024
* fix(dev-server): use `ssrLoadModule` instead of Runtime API

revert #129

* add changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[@hono/vite-dev-server] use Vite Runtime API?
2 participants