Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): add Deno adapter #181

Merged
merged 5 commits into from
Sep 15, 2024
Merged

Conversation

nakasyou
Copy link
Contributor

I added adapter for Deno for build plugin.
It uses Deno.serve.

import denoBuildPlugin from '@hono/vite-build/deno'

Copy link

changeset-bot bot commented Sep 15, 2024

🦋 Changeset detected

Latest commit: 34c7549

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hono/vite-build Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/build/package.json Outdated Show resolved Hide resolved
packages/build/src/adapter/deno/index.ts Outdated Show resolved Hide resolved
@yusukebe
Copy link
Member

Hey @nakasyou

Thank you for the great PR. I've left comments. The reason that the CI is failing is a typo of ./dist/adapter/cloudflate-workers/index.d.ts.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

Hi @nakasyou

The CI is falling with another problem. The test became flaky. But this PR does not have a problem. So, I'll merge this first and fix it later. Thanks!

@yusukebe yusukebe merged commit fc15f71 into honojs:main Sep 15, 2024
1 of 2 checks passed
@github-actions github-actions bot mentioned this pull request Sep 15, 2024
@nakasyou nakasyou deleted the feat/build-deno branch September 15, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants