Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dev-server): add CSP support for vite's injectClientScript option #202

Merged

Conversation

meck93
Copy link
Contributor

@meck93 meck93 commented Jan 2, 2025

fixes #201

Hi @usualoma

Maybe you could have a look at the PR as you've already reviewed my other CSP related PR (honojs/hono#3685). Thanks!

Copy link

changeset-bot bot commented Jan 2, 2025

🦋 Changeset detected

Latest commit: f1bef6c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hono/vite-dev-server Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yusukebe yusukebe changed the title add CSP support for vite's injectClientScript option feat(dev-server): add CSP support for vite's injectClientScript option Jan 5, 2025
@meck93 meck93 force-pushed the 201-add-csp-support-for-vite-inject-client-script branch from ffba6e6 to f1bef6c Compare January 5, 2025 11:42
@meck93 meck93 requested a review from yusukebe January 5, 2025 11:42
@meck93
Copy link
Contributor Author

meck93 commented Jan 5, 2025

@yusukebe once the PR is merged. I can update the HonoX README regarding the nonce attribute: https://github.com/honojs/honox?tab=readme-ov-file#nonce-attribute

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

yusukebe commented Jan 5, 2025

@meck93

Looks good! I'll merge this PR and release a new version.

once the PR is merged. I can update the HonoX README regarding the nonce attribute

Please! Thank you for your contribution.

@yusukebe yusukebe merged commit 3eae0ff into honojs:main Jan 5, 2025
3 checks passed
@github-actions github-actions bot mentioned this pull request Jan 5, 2025
@meck93 meck93 deleted the 201-add-csp-support-for-vite-inject-client-script branch January 5, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSP support for vite's injectClientScript
2 participants