feat(dev-server): support c.env.ASSETS for CF Pages

[yusukebe]

Resolves #17

[yusukebe]

Hi @yudai-nkt!

I was able to fix the env.ASSET.fetch issue with this PR. Could you review it?

[yudai-nkt]

that's cool thanks! i'm afraid i won't have time right now, but will check this on the weekend.

[yudai-nkt]

I tried this fix with the reproduction repo in #17 (comment), but unfortunately I'm still getting the following error:

✘ [ERROR] Error: Could not proxy request: TypeError: fetch failed

      at
  /Users/ynkt/src/github.com/yudai-nkt/hono-vite-plugin-with-env-assets/node_modules/wrangler/wrangler-dist/cli.js:108453:29
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
      at async #handleLoopbackCustomService
  (/Users/ynkt/src/github.com/yudai-nkt/hono-vite-plugin-with-env-assets/node_modules/miniflare/dist/src/index.js:7798:24)
      at async #handleLoopback
  (/Users/ynkt/src/github.com/yudai-nkt/hono-vite-plugin-with-env-assets/node_modules/miniflare/dist/src/index.js:7842:20)

Vite config is as follows:

import { type UserConfig } from "vite";
import pages from "@hono/vite-cloudflare-pages";
import { defaultOptions } from "@hono/vite-dev-server";

// copied from packages/dev-server/src/dev-server.ts in this PR
import { devServer } from "./plugin";

export default {
  plugins: [
    pages(),
    devServer({
      exclude: [...defaultOptions.exclude, /^\/assets\/.+/],
      cf: { assets: true }
    }),
  ],
} satisfies UserConfig;

[yusukebe]

@yudai-nkt

Weird. I've cloned it and tried to run it with this PR's version, and it works fine.

By the way, I used the vite dev command without wrangler. Could you try it again?

[yudai-nkt]

Uh, I was using wrangler pages dev -- vite and port 8788. vite dev and port 5173 work fine, thanks! IIUC, we don't need to directly call wrangler during development because the plugin takes care of binding and other stuff, is that correct?

[yusukebe]

Great!

IIUC, we don't need to directly call wrangler during development because the plugin takes care of binding and other stuff, is that correct?

Yes, we should use only Vite.

[yusukebe]

Okay! I'll ship it now.

[yudai-nkt]

Hi @yusukebe, it looks like you published this PR as @hono/[email protected] but it should be @hono/vite-cloudflare-pages I suppose.

[yusukebe]

Hi, @yudai-nkt .

Ah! The tag name was wrong! But, the npm package name is correct: https://www.npmjs.com/package/@hono/vite-cloudflare-pages. So you can use the v0.1.0 now.

[yudai-nkt]

sorry, i meant @hono/vite-dev-server instead of cloudflare pages. latest release doesn't seem to include this pr: https://www.npmjs.com/package/@hono/vite-dev-server

[yusukebe]

@yudai-nkt

Super sorry! I've published v0.2.0 of @hono/vite-dev-server, now.

[yudai-nkt]

thanks, I'll try it tonight!