Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gateway] encode session response manually to obtain any error beforehand #628

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

sandromello
Copy link
Contributor

@sandromello sandromello commented Jan 3, 2025

  • fix segment to propagate environment names properly
  • prevent errors when parsing user context on http tracing
  • remove legacy cors header x-backend-api

Related to #625: it improves the response from the server to avoid returning empty OK responses.

fix segment to propagate environment names properly
prevent errors when parsing user context on http tracing
remove legacy cors header x-backend-api
@sandromello sandromello requested a review from rogefm January 3, 2025 12:50
@sandromello sandromello changed the title encode session response manually to obtain any error beforehand [gateway] encode session response manually to obtain any error beforehand Jan 3, 2025
@sandromello sandromello merged commit ac19157 into main Jan 3, 2025
1 check passed
@sandromello sandromello deleted the enhanc/get-session-by-id branch January 3, 2025 14:01
Copy link

sentry-io bot commented Jan 4, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ *errors.errorString: failed starting slack service, err=fail to validate slack bot token authentication, err=invalid_auth github.com/hoophq/hoop/gateway/api/plugins in P... View Issue
  • ‼️ *errors.errorString: failed saving new user group [email protected]/[email protected], err=duplicated key not allowed github.com/hoophq/hoop/gateway/api/login in (*h... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant