Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE 555 : Expose an option to disable canonical check while adding a new schema version #556

Merged

Conversation

raju-saravanan
Copy link
Collaborator

@raju-saravanan raju-saravanan commented May 21, 2019

@raju-saravanan raju-saravanan requested a review from joylyn May 21, 2019 19:00
@raju-saravanan
Copy link
Collaborator Author

@joylyn I merged the changes for UI from HDF3.2 to master. Can you double check if the UI changes all are in place?

Copy link
Contributor

@joylyn joylyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raju-saravanan I have verified that the UI changes are in place. LGTM.

@satishd
Copy link
Contributor

satishd commented May 23, 2019

@raju-saravanan I could not build these changes in my environment. Can you confirm whether you could build this PR in your environment?
@kamalcph Can you also build/verify these changes?

results :

Failed tests:
  ManagedTransactionTest.testExecuteConsumerIgnoreRollbackCase:165 null
  ManagedTransactionTest.testExecuteConsumerRollbackCase:152 null
  ManagedTransactionTest.testExecuteFunctionIgnoreRollbackCase:104 null
  ManagedTransactionTest.testExecuteFunctionRollbackCase:91 null
Tests in error:
  ManagedTransactionTest.testCaseCommitTransactionThrowsException:173 NoClassDefFound
  ManagedTransactionTest.testCaseCommitTransactionThrowsExceptionAfterCaseIgnoreRollbackException:201 ExceptionInInitializer
  ManagedTransactionTest.testCaseRollbackTransactionThrowsException:229 NoClassDefFound
  ManagedTransactionTest.testExecuteConsumerArg0SuccessCase:111 NullPointer
  ManagedTransactionTest.testExecuteConsumerArg1SuccessCase:117 NullPointer
  ManagedTransactionTest.testExecuteConsumerArg2SuccessCase:123 NullPointer
  ManagedTransactionTest.testExecuteConsumerArg3SuccessCase:129 NullPointer
  ManagedTransactionTest.testExecuteConsumerArg4SuccessCase:135 NullPointer
  ManagedTransactionTest.testExecuteConsumerArg5SuccessCase:141 NullPointer
  ManagedTransactionTest.testExecuteFunctionArg0SuccessCase:41 NullPointer
  ManagedTransactionTest.testExecuteFunctionArg1SuccessCase:48 NullPointer
  ManagedTransactionTest.testExecuteFunctionArg2SuccessCase:55 NullPointer
  ManagedTransactionTest.testExecuteFunctionArg3SuccessCase:62 NullPointer
  ManagedTransactionTest.testExecuteFunctionArg4SuccessCase:69 NullPointer
  ManagedTransactionTest.testExecuteFunctionArg5SuccessCase:78 NullPointer

@raju-saravanan
Copy link
Collaborator Author

@satishd: I was able to build the PR. @kamalcph and @joylyn Can you guys confirm as well?

@kamalcph
Copy link
Contributor

I'm able to build this PR.

@raju-saravanan
Copy link
Collaborator Author

@satishd: Please confirm if you are able to build this PR, after your confirmation I will merge this PR.

Copy link
Contributor

@satishd satishd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raju-saravanan It seems I am getting the wrong javaassist module from an internal artifactory in my environment. I am fine with the changes as others wee able to build it successfully.

+1 LGTM

@satishd
Copy link
Contributor

satishd commented May 24, 2019

@raju-saravanan I am not able to commit as the permissions seem to be revoked for me. You can merge these changes.

@vijayk Can you add admin permissions for me on this project as I am a committer on this project? thanks.

@raju-saravanan
Copy link
Collaborator Author

@satishd : Will merge the PR.

@raju-saravanan raju-saravanan merged commit e160acd into hortonworks:master May 24, 2019
ngorchakova referenced this pull request in ngorchakova/registry Jun 24, 2019
guruchai pushed a commit that referenced this pull request Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants