-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISSUE 555 : Expose an option to disable canonical check while adding a new schema version #556
ISSUE 555 : Expose an option to disable canonical check while adding a new schema version #556
Conversation
… a new schema version
@joylyn I merged the changes for UI from HDF3.2 to master. Can you double check if the UI changes all are in place? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@raju-saravanan I have verified that the UI changes are in place. LGTM.
@raju-saravanan I could not build these changes in my environment. Can you confirm whether you could build this PR in your environment?
|
I'm able to build this PR. |
@satishd: Please confirm if you are able to build this PR, after your confirmation I will merge this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@raju-saravanan It seems I am getting the wrong javaassist module from an internal artifactory in my environment. I am fine with the changes as others wee able to build it successfully.
+1 LGTM
@raju-saravanan I am not able to commit as the permissions seem to be revoked for me. You can merge these changes. @vijayk Can you add admin permissions for me on this project as I am a committer on this project? thanks. |
@satishd : Will merge the PR. |
…a new schema version (#556)
…a new schema version (#556)
#555