Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-624 : Give executable permissions to all registry scripts #616

Merged
merged 3 commits into from
Nov 21, 2019
Merged

ISSUE-624 : Give executable permissions to all registry scripts #616

merged 3 commits into from
Nov 21, 2019

Conversation

suminb
Copy link
Contributor

@suminb suminb commented Nov 12, 2019

I've noticed the following scripts do not have executable permissions.

  • bin/registry
  • bin/registry-server-start.sh
  • bootstrap/bootstrap-storage-initenv.sh
  • bootstrap/bootstrap-storage.sh

I would be nice to be able to run these files without manually giving executable permissions.

@raju-saravanan
Copy link
Collaborator

Fixes #624

@raju-saravanan raju-saravanan changed the title Give executable permissions ISSUE-624 : Give executable permissions Nov 18, 2019
@raju-saravanan raju-saravanan changed the title ISSUE-624 : Give executable permissions ISSUE-624 : Give executable permissions to bootstrap scripts Nov 18, 2019
@raju-saravanan raju-saravanan self-requested a review November 18, 2019 10:01
@raju-saravanan
Copy link
Collaborator

@suminb thanks for the PR. Can you set the same permissions to /conf/registry-env.sh as well ?

@suminb
Copy link
Contributor Author

suminb commented Nov 18, 2019

Done. However, I found other *.sh files without executable permissions.

$ find . ! -perm -u+x -name "*.sh"
./docker/images/kafka/kafka-service.sh
./docker/images/registry/start-registry.sh
./docker/kdc-registry.sh
./webservice/target/node/node_modules/npm/test/packages/npm-test-ignore/test.sh
./webservice/target/node/node_modules/npm/test/packages/npm-test-files/test.sh
./webservice/target/node/node_modules/npm/scripts/release.sh
./webservice/src/main/resources/node_modules/react-breadcrumbs/demo/surge.sh
./webservice/src/main/resources/node_modules/react-breadcrumbs/demo/run.sh
./webservice/src/main/resources/node_modules/coa/lib/completion.sh
./webservice/src/main/resources/node_modules/sourcemapped-stacktrace/demo/make.sh
./webservice/src/main/resources/node_modules/JSV/jsdoc-toolkit/jsrun.sh
./webservice/src/main/resources/node_modules/object.assign/test.sh

I would assume packages under node_modules directories are managed by npm so we don't have to worry about them. But should we also give executable permissions on script files under the docker directory?

@raju-saravanan
Copy link
Collaborator

@suminb Yeah, the docker scripts need the execute permissions. We don't need to set executable permissions for scripts run by npm.

@suminb
Copy link
Contributor Author

suminb commented Nov 19, 2019

All done.

@raju-saravanan raju-saravanan changed the title ISSUE-624 : Give executable permissions to bootstrap scripts ISSUE-624 : Give executable permissions to registry scripts Nov 21, 2019
@raju-saravanan raju-saravanan changed the title ISSUE-624 : Give executable permissions to registry scripts ISSUE-624 : Give executable permissions to all registry scripts Nov 21, 2019
Copy link
Collaborator

@raju-saravanan raju-saravanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM, thanks @suminb for the PR.

@raju-saravanan raju-saravanan merged commit 67b30db into hortonworks:master Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants