Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISSUE-656: Delete schema metadata when invalid schema is added #657

Merged
merged 1 commit into from
Jan 27, 2020
Merged

ISSUE-656: Delete schema metadata when invalid schema is added #657

merged 1 commit into from
Jan 27, 2020

Conversation

joylyn
Copy link
Contributor

@joylyn joylyn commented Jan 24, 2020 •
edited by raju-saravanan
Loading

Fixes #656

@joylyn joylyn requested a review from raju-saravanan January 24, 2020 05:52
@raju-saravanan
Copy link
Collaborator

@joylyn: Can we show the error message from schema version addition (2nd call), it will be more useful for the end-users to understand what went wrong with the schema addition

@joylyn
Copy link
Contributor Author

joylyn commented Jan 24, 2020

@raju-saravanan I have pushed the code review changes.

raju-saravanan
raju-saravanan approved these changes Jan 27, 2020
View reviewed changes
Copy link
Collaborator

@raju-saravanan raju-saravanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joylyn for the PR.

@raju-saravanan raju-saravanan merged commit 47e73d8 into hortonworks:master Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raju-saravanan raju-saravanan raju-saravanan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delete schema metadata when invalid schema is added
2 participants
@joylyn @raju-saravanan